Re: [ft-devel] otvalid modules

[George Williams]

On Sat, 2007-08-11 at 01:22, Werner LEMBERG wrote:
> Applied.  However, I think there is a mistake for the
> SingleSubstFormat1 case:
> 
>         idx = otv_Coverage_get_first( Coverage ) + DeltaGlyphID;
>         if ( idx < 0                                           ||
>              idx + DeltaGlyphID < 0                            ||
>              (FT_UInt)idx + DeltaGlyphID >= valid->glyph_count )
>           FT_INVALID_GLYPH_ID;
> 
> The code adds DeltaGlyphID to idx, and then you are checking whether
> `idx + DeltaGlyphID < 0'...  This looks wrong to me.  I don't have
> time currently to verify this.  Please post a patch if necessary.
DeltaGlyphID can be a negative value, so I think it's a reasonable
check.