Re: [ft-devel] otvalid modules

[Werner LEMBERG]

> Please apply the otvmathconstant patch

Applied.

> The patch coverageCount passes an extra argument to
> otv_Coverage_validate (the expected number of glyphs, or -1 if this
> is not known -- it isn't always) and then checks that these counts
> match.

Applied.

> I may be wrong, and perhaps the authors had something else in mind
> and my patch may be inappropriate. So please examine the invalidGID
> patch and only apply it if appropriate.

Applied.  However, I think there is a mistake for the
SingleSubstFormat1 case:

        idx = otv_Coverage_get_first( Coverage ) + DeltaGlyphID;
        if ( idx < 0                                           ||
             idx + DeltaGlyphID < 0                            ||
             (FT_UInt)idx + DeltaGlyphID >= valid->glyph_count )
          FT_INVALID_GLYPH_ID;

The code adds DeltaGlyphID to idx, and then you are checking whether
`idx + DeltaGlyphID < 0'...  This looks wrong to me.  I don't have
time currently to verify this.  Please post a patch if necessary.


    Werner