Re: [ft-devel] bug fix: pointers in FT_Open_Args should be const

[David Turner]

No, this is *not* fine, this is a API breakage, and it will prevent
some client sources from compilation. This already happened when you
changed to type of parameters to the outline decomposition functions.

It's unfortunate that these parameters are not const, but very frankly
I don't see why we should bother clients for such a petty thing.

Please do *not* apply. Update the documentation if you want.

Regards,

- David


On Sun, 28 Jan 2007 01:19:17 +0100 (CET), "Werner LEMBERG" <address@hidden> 
said:
> 
> > Thus FT_Open_Args ought to change from
> >
> >   typedef struct  FT_Open_Args_
> >   {
> >     FT_UInt         flags;
> >     const FT_Byte*  memory_base;
> >     FT_Long         memory_size;
> >     FT_String*      pathname;
> >     FT_Stream       stream;
> >     FT_Module       driver;
> >     FT_Int          num_params;
> >     FT_Parameter*   params;
> >
> >   } FT_Open_Args;
> >
> > to
> >
> >   typedef struct  FT_Open_Args_
> >   {
> >     FT_UInt         flags;
> >     const FT_Byte*  memory_base;
> >     FT_Long         memory_size;
> >     const FT_String*      pathname;
> >     FT_Stream       stream;
> >     FT_Module       driver;
> >     FT_Int          num_params;
> >     const FT_Parameter*   params;
> >
> >   } FT_Open_Args;
> 
> This is fine with me.  David?
> 
> 
>     Werner
> 
> 
> _______________________________________________
> Freetype-devel mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/freetype-devel