[Git][freetype/freetype-demos][gsoc-2022-chariri] [ftinspect] Add missing event connections for setting panel.

[Charlie Jiang (@cqjjjzr)]

Charlie Jiang pushed to branch gsoc-2022-chariri at FreeType / FreeType Demo Programs

Commits:

• 3b05fb4c
  by Charlie Jiang at 2022-07-02T20:16:03+08:00

  [ftinspect] Add missing event connections for setting panel.
  
  Some event connections are missing, so the glyph view can't be updated in time
  when the settings changes. This commit fixes this.
  
  * src/ftinspect/panels/settingpanel.cpp: Add connections for `gammaSlider_`,
    `hintingCheckBox_`, `horizontalHintingCheckBox_`,
    `verticalHintingCheckBox_`, `blueZoneHintingCheckBox_` and
    `segmentDrawingCheckBox_`.
  

1 changed file:

• src/ftinspect/panels/settingpanel.cpp

Changes:

src/ftinspect/panels/settingpanel.cpp

---

...	...	@@ -236,9 +236,6 @@ SettingPanel::syncSettings()
236	236	void
237	237	SettingPanel::createConnections()
238	238	{
239		- connect(hintingCheckBox_, &QCheckBox::clicked,
240		- this, &SettingPanel::checkHinting);
241		-
242	239	// use `qOverload` here to prevent ambiguity.
243	240	connect(hintingModeComboBox_,
244	241	qOverload<int>(&QComboBox::currentIndexChanged),
...	...	@@ -250,7 +247,21 @@ SettingPanel::createConnections()
250	247	qOverload<int>(&QComboBox::currentIndexChanged),
251	248	this, &SettingPanel::checkLCDFilter);
252	249
253		- // TODO: some connections are missing
	250	+ connect(gammaSlider_, &QSlider::valueChanged,
	251	+ this, &SettingPanel::repaintNeeded);
	252	+
	253	+ connect(hintingCheckBox_, &QCheckBox::clicked,
	254	+ this, &SettingPanel::checkHinting);
	255	+
	256	+ connect(horizontalHintingCheckBox_, &QCheckBox::clicked,
	257	+ this, &SettingPanel::repaintNeeded);
	258	+ connect(verticalHintingCheckBox_, &QCheckBox::clicked,
	259	+ this, &SettingPanel::repaintNeeded);
	260	+ connect(blueZoneHintingCheckBox_, &QCheckBox::clicked,
	261	+ this, &SettingPanel::repaintNeeded);
	262	+ connect(segmentDrawingCheckBox_, &QCheckBox::clicked,
	263	+ this, &SettingPanel::repaintNeeded);
	264	+
254	265	connect(autoHintingCheckBox_, &QCheckBox::clicked,
255	266	this, &SettingPanel::checkAutoHinting);
256	267	connect(showBitmapCheckBox_, &QCheckBox::clicked,

—
View it on GitLab.
You're receiving this email because of your account on gitlab.freedesktop.org. If you'd like to receive fewer emails, you can adjust your notification settings.