|
From: | No Wayman |
Subject: | Re: Org mode version 9.7-pre (9.7-pre-n/a-g63e8ca @ /home/n/.emacs.d/elpaca/builds/org/); [PATCH]: fix ob-lilypond docstrings |
Date: | Thu, 24 Aug 2023 08:56:54 -0400 |
User-agent: | mu4e 1.11.15; emacs 30.0.50 |
Ihor Radchenko <yantar92@posteo.net> writes:
No Wayman <iarchivedmywholelife@gmail.com> writes:The attached patch satisfies all but two checkdoc warnings. I left those two for someone more familiar with the package.Thanks!Subject: [PATCH] * lisp/ob-lilypond.el: satisfy checkdoc_S_atisfy.(org-babel-lilypond-compile-post-tangle): fix docstring (org-babel-lilypond-display-pdf-post-tangle): fix docstring (org-babel-lilypond-play-midi-post-tangle): fix docstring (org-babel-execute:lilypond): fix docstring (org-babel-lilypond-tangle): fix docstring (org-babel-lilypond-process-basic): fix docstring (org-babel-lilypond-parse-line-num): fix docstring (org-babel-lilypond-set-header-args): fix docstringIt is enough to say "Fix docstring" just for the last line and leave allother : ... empty.
Fixed in attached patch.
(defun org-babel-lilypond-set-header-args (mode) - "Set org-babel-default-header-args:lilypond -dependent on ORG-BABEL-LILYPOND-ARRANGE-MODE."+ "Set lilypond babel header args from ORG-BABEL-LILYPOND-ARRANGE-MODE."What is ORG-BABEL-LILYPOND-ARRANGE-MODE?
Looks like it's a variable that would be better served by a minor-mode.
#+begin_src emacs-lisp (defvar org-babel-lilypond-arrange-mode nil "Non-nil turns Arrange mode on. In Arrange mode the following settings are altered from default: :tangle yes, :noweb yes :results silent :comments yes.In addition lilypond block execution causes tangling of all lilypond
blocks.") #+end_srcA minor mode would also obviate the need for `org-babel-lilypond-toggle-arrange-mode'.
Let's do that in a separate patch.
0001-lisp-ob-lilypond.el-Satisfy-checkdoc.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |