emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] org-element-timestamp-interpreter: Return daterange anyway,


From: Ilya Chernyshov
Subject: Re: [PATCH] org-element-timestamp-interpreter: Return daterange anyway, if DATERANGE is non-nil
Date: Tue, 11 Jul 2023 20:16:50 +0700

Ihor Radchenko <yantar92@posteo.net> writes:

> The patch looks good in general, but there is at least one test failing
> when I run make test. May you please check?

Inside `org-timestamp-split-range', there was an attempt to intepret a
timestamp object with :type `active'/`inactive' and :range-type
`daterange'/`timerange' which caused an error. Fixed by setting
:range-type to nil before `(org-element-interpret-data split-ts)'.


> Also, see the attached diff where I suggest some comments to explain the
> code logic.

Looks good to me, I just changed a note about
`org-element-timestamp-parser' setting nil for end part if :type is
`active'/`inactive'. That's not true. The actual behavior is that it
sets end date/time to the same values as start date/time even if it's
`active'/`inactive'. So here is the patch:

Attachment: 0001-lisp-org-element.el-Add-new-timestamp-property-range.patch
Description: Text Data

> And please provide an additional patch for WORG:
> https://orgmode.org/worg/dev/org-element-api.html#org6ae377e

Sure.

Attachment: 0001-dev-org-element-api.org-Add-range-type-for-timestamp.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]