[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [BUG] [PATCH] org-odt-plain-text: Fix when text contains only spaces
From: |
Ihor Radchenko |
Subject: |
Re: [BUG] [PATCH] org-odt-plain-text: Fix when text contains only spaces [9.7-pre (release_9.6.4-346-g7d41bd @ /home/cassou/.emacs.d/lib/org/lisp/)] |
Date: |
Sun, 30 Apr 2023 17:27:33 +0000 |
Damien Cassou <damien@cassou.me> writes:
> in [1], Ihor fixed a bug I reported in ox-odt. Unfortunately, this fix
> broke figures with several lines of captions such as:
>
> #+CAPTION: first line,
> #+CAPTION: second line
> [[file:media/myPicture.png]]
>
> This is because, in this case, org-odt-plain-text is called at some
> point with " " as value for `text`. In this context, both `leading` and
> `trailing` temporary variables contain the same value as `text`, making
> the `substring` call crash.
Thanks for the heads-up!
Fixed, on bugfix. Alongside with a couple of ox-odt improvements on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c756f8a85
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c265d964f
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a686c7b60
> The attached patch fixes the issue by considering that there is no
> leading/trailing content when the input only contains spaces.
I used an alternative approach.
Canceled. (for the patch)
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>