emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [DRAFT PATCH v5] Decouple LANG= and testing (was: Test failure due t


From: Ruijie Yu
Subject: Re: [DRAFT PATCH v5] Decouple LANG= and testing (was: Test failure due to LANG)
Date: Tue, 25 Apr 2023 16:02:38 +0800
User-agent: mu4e 1.9.22; emacs 30.0.50

Ihor Radchenko <yantar92@posteo.net> writes:

> (let ((org-time-stamp-formats '("%Y-%m-%d" . "%Y-%m-%d %H:%M")))
>      (org-element-timestamp-interpreter timestamp nil))

Thanks for the pointer.  I have made this into a macro and redid my
changes accordingly.  Please also let me know if more work should be
dedicated to avoid code duplication in tests (I see a lot of duplication
in the portions I touched in testing/lisp/test-org.el).

What currently still fails unexpectedly:

zh_CN.UTF-8:
    test-org-clock/clocktable/lang
    - This test only fails in batch mode, as I mentioned up-thread.  I
      might try to convert this into a test that expects failure
      depending on whether Emacs is in batch mode.
    test-org-colview/columns-width
    - This patch did not attempt to fix it.  I posted a diff file under
      v2 (not included in this patch), but that didn't work either.

ja_JA.UTF-8:
    test-org-colview/columns-width
    - See above.

fr_FR.UTF-8:
    test-org-clok/org-clock-timestamps-change
    - This is tracked in the other thread I created, and won't be fixed
      by this patch.

en_US.UTF-8 and de_DE.UTF-8:
    No unexpected test failures.

Attachment: 0001-DRAFT-Fix-dependence-on-locale-in-org-testing-facili.patch
Description: Text Data

To summarize, the remaining goal of this patchset is to fix
`test-org-colview/columns-width', and to optionally expect-failure on
`test-org-clock/clocktable/lang'.

-- 
Best,


RY

[Please note that this mail might go to spam due to some
misconfiguration in my mail server -- still investigating.]

reply via email to

[Prev in Thread] Current Thread [Next in Thread]