Re: [BUG] Agenda not sorting by priority THEN todo state (todo state ignored) [9.6.1 (9.6.1-??-fe92a3c @ /Users/polofsson/.emacs.d/.local/straight/build-28.2/org/)]

[Ihor Radchenko]

Samuel Wales <samologist@gmail.com> writes:

> i was not intending to talk about that xkcd.  there has been confusion
> about 2 definitions of priority, and your urgent will likely help.  if
> the docs referred to priority cookies, your argument is good.  i did
> not think every reference did incl code.

Well. I am pretty sure that the docstring in org-agenda was talking
about agenda-specific priorities. However, it was against Org's
terminology even 15 years ago - the earliest time I can track the
discussed docstring and manual entry in Git history. Now and earlier,
Org manual introduced priorities as [#A]-[#C] basically everywhere with
a single exception: when talking about agenda default sorting

    "Within each category, items are sorted by priority
    (@pxref{Priorities}), which is composed of the base priority (2000 for
    priority @samp{A}, 1000 for @samp{B}, and 0 for @samp{C}), plus
    additional increments for overdue scheduled or deadline items."

Notably, no reference has been ever made to this statement in the manual
from `org-agenda-sorting-strategy' docstring.

So, the terminology here has been confusing since forever and the only
clue about agenda special treatment of "priority" term has been in the
manual, not even linked to `org-agenda-sorting-strategy',- only to the
"default order" of agenda sorting.

My patch does not affect the default agenda sorting, so the previous
manual's claim is not contradicted. My commit also solves the
terminology confusion. Thus, I observe no regression and see not why we
should not be free to adjust how agenda treats 'priority-up/down in
`org-agenda-sorting-strategy'.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>