Re: [PATCH] Autoload `org-assert-version' and remove org-loaddefs.el

[Ihor Radchenko]

Max Nikulin <manikulin@gmail.com> writes:

>> I was able to reproduce on Debian using virtual machine.
>
> To be precise, I am surprised that you are unable to reproduce the issue 
> with older Emacs version compiled from source.

Does it mean that you are able to?
I only tried on Gentoo, because my Debian-foo is not good enough to hunt
all the required compile-time dependencies for Emacs.

>> https://old.reddit.com/r/orgmode/comments/123qnqq/workaround_for_orgassertversion_problem_not/
>
> I have no clue why your patch should help in this case.

It won't, but the very reason that message appeared is the need to do
that awkward workaround. It must not be needed - we are causing way too
much inconvenience to users of Emacs versions we claim to support.

>>> I am in doubts if emacs version should be checked or it should be e.g.
>>> (fboundp 'org-assert-version).
>> 
>> It is indeed a cleaner approach.
>
> I am not sure. Perhaps it should be (or (fboundp 'org-assert-version) 
> (new-package-management-code)). Since testing for private function is 
> not a reliable solution, only version check is available.

May you elaborate?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>