Re: [PATCH] Autoload `org-assert-version' and remove org-loaddefs.el

[Max Nikulin]

On 29/03/2023 23:52, Ihor Radchenko wrote:
> Max Nikulin writes:
> > Sorry, I have not tried to compile Emacs myself and I am really puzzled
> > why you was not able to reproduce the issue.
>
> I was able to reproduce on Debian using virtual machine.

To be precise, I am surprised that you are unable to reproduce the issue 
with older Emacs version compiled from source.

> https://old.reddit.com/r/orgmode/comments/123qnqq/workaround_for_orgassertversion_problem_not/

I have no clue why your patch should help in this case.

My hypothesis: the user has `use-package' org-roam in their init file. 
Attempt to update org caused compiling new org when old version is 
already loaded due to Emacs-27 does not contain fixes that reload 
package that is installed. Next time load of org failed because it is 
result of mixed version compilation.

> > I am in doubts if emacs version should be checked or it should be e.g.
> > (fboundp 'org-assert-version).
>
> It is indeed a cleaner approach.

I am not sure. Perhaps it should be (or (fboundp 'org-assert-version) 
(new-package-management-code)). Since testing for private function is 
not a reliable solution, only version check is available.