emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] lisp/ob-screen.el: Support ~:var~ header args for babel bloc


From: Ken Mankoff
Subject: Re: [PATCH] lisp/ob-screen.el: Support ~:var~ header args for babel blocks
Date: Sat, 25 Feb 2023 07:19:25 -0800

I note that `org-babel-screen-test` fails, but it appears to fail before this change too...

  -k.

On Sat, Feb 25, 2023 at 7:14 AM Ken Mankoff <mankoff@gmail.com> wrote:
Hi Max,

On 2023-02-24 at 19:51 -08, Max Nikulin <manikulin@gmail.com> wrote:
> On 25/02/2023 01:33, Ken Mankoff wrote:
> I am unsure if Org markup is suitable for commit messages (~:var~)
> since it may appear in Emacs commit logs.

Fixed.

> The code still depends on on ob-shell. Is there a reason why calling
> `org-babel-variable-assignments:shell' is a worse variant than copy of
> the whole function body?

I didn't realize that was a dependency. I now use that function. This also means that arrays/tables/etc. are all supported by :var, although not in the default screen ":cmd sh" because sh doesn't support "declare", but it works with ":cmd bash".

Improved patch attached.

Thanks,

  -k.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]