emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] remove unused code in ob-octave.el


From: Max Nikulin
Subject: Re: [PATCH] remove unused code in ob-octave.el
Date: Fri, 10 Feb 2023 09:32:05 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1

On 10/02/2023 04:21, Leo Butler wrote:
In lisp/ob-octave.el:

What is the point of ob-octave-prep-session:octave or its brother,
ob-octave-prep-session:matlab?

These two functions are unused in the existing code.

Have you checked the following? I am not familiar with org-babel code.

grep -nH org-babel-prep-session lisp/ob-core.el
lisp/ob-core.el:1041: (prep-cmd (intern (concat "org-babel-prep-session:" lang)))) lisp/ob-core.el:1050: (error "No org-babel-prep-session function for %s!" lang))

Do test passes when you patch is applied? It might mean that test coverage is not perfect.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]