[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] ob-eval: display error fix
From: |
Andreas Gerler |
Subject: |
Re: [O] [PATCH] ob-eval: display error fix |
Date: |
Fri, 3 Feb 2023 18:04:54 +0100 |
Hi Ihor,
way too busy right now.
As soon as I find some time I’ll rework that change. Might take a week or two.
so long...
Andreas Gerler
> On Jan 27, 2023, at 2:11 PM, Ihor Radchenko <yantar92@posteo.net> wrote:
>
> Andreas Gerler <baron@bundesbrandschatzamt.de> writes:
>
>> +(defcustom org-babel-eval-error-display-notify nil
>> + "Display org-babel-eval-errors always or only if exit code is not 0."
>
> This docstring is confusing. What will happen if the value is nil?
> non-nil? I cannot answer these questions by reading the docstring.
>
> Also, what is "org-babel-eval-errors"? Symbol?
>
> Finally, I do not think that "nil" is a good default here. It is better
> to display warnings by default and let people disable them only
> consciously, when needed. Ideally, we may allow the value to be a list
> of backends where to display/not display the warnings.
>
>> + :group 'org-babel
>> + :version "29.1"
>
> Please use :package-version instead.
>
> And add the new customization to etc/ORG-NEWS.
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [O] [PATCH] ob-eval: display error fix,
Andreas Gerler <=