[PATCH] Fix `org-lint-link-to-local-file'

[Ihor Radchenko]

I have been trying to run org-lint on my files recently. Ended up fixing 
org-lint itself...

See the attached.

Best,
Ihor

>From feacb6fd2898b5788e6d70b3139cf83359b96ca6 Mon Sep 17 00:00:00 2001
From: Ihor Radchenko <yantar92@gmail.com>
Date: Sat, 26 Sep 2020 14:24:44 +0800
Subject: [PATCH] Fix `org-lint-link-to-local-file'.

* lisp/org-lint.el (org-lint-link-to-local-file): 1. Fix call to
`org-attach-expand' being called with point not at the attachment:
link.  2. Fix typo in call to `format'.  File argument had to be
outside the if.
---
 lisp/org-lint.el | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lisp/org-lint.el b/lisp/org-lint.el
index 79ad640e4..e4e0ef751 100644
--- a/lisp/org-lint.el
+++ b/lisp/org-lint.el
@@ -574,15 +574,16 @@ Use :header-args: instead"
           (let* ((path (org-element-property :path l))
                  (file (if (string= type "file")
                            path
-                         (org-attach-expand path))))
+                          (org-with-point-at (org-element-property :begin l)
+                           (org-attach-expand path)))))
             (and (not (file-remote-p file))
                  (not (file-exists-p file))
                  (list (org-element-property :begin l)
                        (format (if (org-element-lineage l '(link))
                                    "Link to non-existent image file %S \
 in description"
-                                 "Link to non-existent local file %S"
-                                 file))))))
+                                 "Link to non-existent local file %S")
+                                file)))))
          (_ nil))))))
 
 (defun org-lint-non-existent-setupfile-parameter (ast)
-- 
2.26.2