[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Omit file description when :file-desc has nil value
From: |
Matt Huszagh |
Subject: |
Re: [PATCH] Omit file description when :file-desc has nil value |
Date: |
Wed, 09 Sep 2020 12:50:38 -0700 |
Kyle Meyer <kyle@kyleam.com> writes:
> I also don't find the current behavior particularly intuitive. (I'm
> also not really a babel user, so my opinion probably shouldn't count for
> much.) If we were adding it today, I think what you describe would be
> better, but, as you mention, breakage also now also weighs against
> making a change here.
>
> In any case, I'd suggest raising the discussion on the list after the
> 9.4 release.
Ok, I'll follow up on this then.
>>> Right, to reflect the current behavior established as a result of the
>>> above thread, I think that should be reworded to distinguish between an
>>> absent :file-desc header and one with no argument. Sorry for not
>>> catching that when reviewing your initial patch.
>>
>> No worries, and I agree the documentation should be updated. I'm happy
>> to provide the patch myself, but I'd like to talk through whether the
>> current implementation is the correct one before I do.
>
> Thanks. To avoid any confusion coming from this description making it
> into the 9.4 release, I've updated it in 4b2123fb7.
Thanks for fixing that Kyle.
Matt
- [PATCH] Omit file description when :file-desc has nil value, Matt Huszagh, 2020/09/03
- [PATCH] Omit file description when :file-desc has nil value, Huszaghmatt, 2020/09/05
- Re: [PATCH] Omit file description when :file-desc has nil value, Kyle Meyer, 2020/09/06
- Re: [PATCH] Omit file description when :file-desc has nil value,
Matt Huszagh <=
- Re: [PATCH] Omit file description when :file-desc has nil value, Matt Huszagh, 2020/09/15
- Re: [PATCH] Omit file description when :file-desc has nil value, Kyle Meyer, 2020/09/24
- Re: [PATCH] Omit file description when :file-desc has nil value, Matt Huszagh, 2020/09/24
- Re: [PATCH] Omit file description when :file-desc has nil value, Kyle Meyer, 2020/09/24
- Re: [PATCH] Omit file description when :file-desc has nil value, Matt Huszagh, 2020/09/29