Re: /ame source

[J.P.]

Emanuel Berg <incal@dataswamp.org> writes:

> J.P. wrote:
>
>> I wonder if we should instead change the behavior to match
>> the doc string because I thought only commands that start
>> with G ("global") are meant to affect all servers. IOW, why
>> not copy the existing functionality to a /GMSG and make
>> /AMSG only affect channels on the current server?

And beneath that,

> J.P. wrote:
      ^ also

>> Please send separate patches against the source tree to the
>> bug tracker.
>
> Gladly, but how do I do that? Are there instructions for
> that anywhere?

I was under the impression this meant you were willing to send git-am(1)
committable patches or at least git-apply(1)'able "combined diff" hunks.
If not, how am I to install these? Who is the author supposed to be?

See also:

  https://git.savannah.gnu.org/cgit/emacs.git/tree/admin/notes/git-workflow

If you can't be bothered, your favorite LLM should be able to convert
your listings into proper patches. Try feeding it the original source
file and its location in the tree (e.g., lisp/erc/erc.el) along with the
contents of CONTRIBUTE and all the emails in this thread, plus the usual
dollop of elbow grease. If it comes through, please submit the output as
an attachment to M-x erc-bug RET or similar, and put "Tags: patch\n\n"
above the generated boilerplate. Thanks.

> Not sure if that warning part of the docstring can be used
> repeatedly without copying/hardcoding it each time - if so,
> that would be better.
>
> (defun erc-cmd-GME (line)
>   "Send LINE as an action to all channels on all networks.
> \nWarning: Use of this function is considered spamming;
>          it is included for testing purposes only."
>   (interactive "sSend action to all channels on all networks: ")
>   (erc-with-all-buffers-of-server nil
>     (lambda () (erc-channel-p (erc-default-target)))
>     (erc-cmd-ME line) ))
> (put 'erc-cmd-GME 'do-not-parse-args t)
>
> (defun erc-cmd-AME (line)
>   "Send LINE as an action to all channels on the current network.
> \nWarning: Use of this function is considered spamming;
>          it is included for testing purposes only."
>   (interactive "sSend action to all channels on this network: ")
>   (erc-with-all-buffers-of-server erc-server-process
>     (lambda () (erc-channel-p (erc-default-target)))
>     (erc-cmd-ME line) ))
> (put 'erc-cmd-AME 'do-not-parse-args t)