|
From: | J.P. |
Subject: | bug#67032: 30.0.50; ERC 5.6-git: Treat erc-send-message more responsibly |
Date: | Thu, 09 Nov 2023 18:26:51 -0800 |
User-agent: | Gnus/5.13 (Gnus v5.13) |
Tags: patch The function `erc-send-message', as used in-tree, sends and inserts messages produced by handlers for certain slash commands. But rather than being a simplistic analog for `erc-send-current-line', it's used in practice to take over for that function in situations where the actual prompt input is modified or replaced (and possibly reprocessed anew as simulated "meta" input, as is the case with /SAY). From the user's perspective, such messages are supposed to look and feel like all other outgoing chat messages. However, at present, they don't. I was originally hoping to introduce these changes for the next release, but a bug has surfaced that exposes a major problem with the current implementation. >From emacs -Q: 1. Connect and join a channel 2. Type /sm RET at the prompt 3. Check the server buffer for a "message too long" error The issue here is not that we've reached a module count large enough to tip the outgoing text produced by `erc-modes' over the byte limit but rather that `erc-send-message' has outgrown its usefulness and must now evolve into something more robust and capable (in a backward compatible way, of course). In tackling this, I've opted to sidestep a few related concerns that will have to be dealt with eventually. The first has to do with discovering and possibly reintegrating whatever role the `noncommands' module is designed to play in processing specialty slash commands, like those reliant on `erc-send-message'. These days (reaching as far back as Emacs 26.1), the module appears to effectively be a no-op, at least with the default client configuration. Until we know more, I'm inclined to let it rot away in erc-goodies, since its code only runs on interactive input anyway. Another issue I've avoided confronting with these changes is the ugly relationship between `erc-format-privmessage', `erc-server-PRIVMSG', `erc-format-nick-function', and `erc-display-message'. Sooner or later, most of the speaker-related formatting shared between this bunch will need to be consolidated and likely made accessible from `erc-display-message' alone so that various next-gen features, such as displaying messages from other devices sharing the same presence, can be handled properly and made to look like the result of local prompt input. All in good time, I guess. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.6) of 2023-11-09 built on localhost Repository revision: 9c9b87639f919169eed956e9e7cce472d3a2f719 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Fedora Linux 37 (Workstation Edition) Configured using: 'configure --enable-check-lisp-object-type --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3' PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils erc auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map format-spec cl-loaddefs cl-lib erc-backend erc-networks byte-opt gv bytecomp byte-compile erc-common erc-compat erc-loaddefs rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 66646 9545) (symbols 48 8720 0) (strings 32 23596 1638) (string-bytes 1 688941) (vectors 16 16134) (vector-slots 8 216395 14139) (floats 8 24 47) (intervals 56 242 0) (buffers 984 10))
0001-5.6-Make-ERC-error-notice-formatting-more-consistent.patch
Description: Text Data
0002-5.6-Make-ERC-s-message-sending-functions-more-flexib.patch
Description: Text Data
0003-5.6-Simplify-logic-for-inserting-ERC-prompt-input.patch
Description: Text Data
0004-5.6-Slightly-simplify-text-props-on-echoed-ERC-input.patch
Description: Text Data
0005-5.6-Don-t-output-non-modules-in-erc-modes.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |