emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/org-remark d72fa0ef45 70/75: fix: regression next/prev-


From: ELPA Syncer
Subject: [elpa] externals/org-remark d72fa0ef45 70/75: fix: regression next/prev-view opens the notes when there is none
Date: Fri, 6 Oct 2023 12:59:21 -0400 (EDT)

branch: externals/org-remark
commit d72fa0ef458514726be754b9b8c2d2b9d00ddda3
Author: Noboru Ota <me@nobiot.com>
Commit: Noboru Ota <me@nobiot.com>

    fix: regression next/prev-view opens the notes when there is none
    
    org-remark-view, org-remark-view-[next|prev] should not open the
    marginal notes buffer when there is no highlights under cursor or in the
    current (narrowed part of) buffer.
---
 org-remark.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/org-remark.el b/org-remark.el
index 9abb94c458..53c682fb40 100644
--- a/org-remark.el
+++ b/org-remark.el
@@ -6,7 +6,7 @@
 ;; URL: https://github.com/nobiot/org-remark
 ;; Version: 1.2.1
 ;; Created: 22 December 2020
-;; Last modified: 01 September 2023
+;; Last modified: 09 September 2023
 ;; Package-Requires: ((emacs "27.1") (org "9.4"))
 ;; Keywords: org-mode, annotation, note-taking, marginal-notes, wp,
 
@@ -577,7 +577,8 @@ side-window (as defined by user option
     ;; to open in a normal way but open the margnal notes buffer with
     ;; find-file.
     (if (or (eql (prefix-numeric-value current-prefix-arg) 4)
-            (not ov))
+            ;; :view-only should not open the marginal notes buffer
+            (and (null ov) (not (eql view-only :view-only))))
         (let ((notes-file (org-remark-notes-get-file-name)))
           (when (file-exists-p notes-file) (find-file notes-file)))
       ;; Open marginal notes normally as an indirect buffer in a side



reply via email to

[Prev in Thread] Current Thread [Next in Thread]