[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/dracula-theme e4672e2 137/187: Do not advertize dracula-us
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/dracula-theme e4672e2 137/187: Do not advertize dracula-use-24-bit-colors-on-256-colors-terms in README |
Date: |
Thu, 21 Oct 2021 18:05:10 -0400 (EDT) |
branch: elpa/dracula-theme
commit e4672e22885772d2be0c75df03c4f805f1acf5fa
Author: Étienne Deparis <etienne@depar.is>
Commit: Étienne Deparis <etienne@depar.is>
Do not advertize dracula-use-24-bit-colors-on-256-colors-terms in README
The issue 59 proves again that 256 colors terminal cannot handle the
24bit colors of the graphical definition. Thus regular user should not
try to activate this new setting, or, if they want to, must fully
aknowledge the possible drawbacks.
I also add a long comment to this setting to explain one of the possible
problems and a solution to it.
See: https://github.com/dracula/emacs/issues/59
---
README.md | 3 ---
dracula-theme.el | 20 ++++++++++++++++----
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/README.md b/README.md
index c9be0df..b607b0c 100644
--- a/README.md
+++ b/README.md
@@ -36,9 +36,6 @@ need to be set before `load-theme` is invoked for Dracula.
;; Use less pink and bold on the mode-line and minibuffer (default nil)
(setq dracula-alternate-mode-line-and-minibuffer t)
-
-;; Force 24 bit colors (regular colors) on terminals (default nil)
-(setq dracula-use-24-bit-colors-on-256-colors-terms t)
```
## Test
diff --git a/dracula-theme.el b/dracula-theme.el
index e168a94..7be48e0 100644
--- a/dracula-theme.el
+++ b/dracula-theme.el
@@ -56,10 +56,22 @@ The theme has to be reloaded after changing anything in
this group."
:type 'boolean
:group 'dracula)
-(defcustom dracula-use-24-bit-colors-on-256-colors-terms nil
- "Use true colors even on terminals announcing less capabilities."
- :type 'boolean
- :group 'dracula)
+(defvar dracula-use-24-bit-colors-on-256-colors-terms nil
+ "Use true colors even on terminals announcing less capabilities.
+
+Beware the use of this variable. Using it may lead to unwanted
+behavior, the most common one being an ugly blue background on
+terminals, which don't understand 24 bit colors. To avoid this
+blue background, when using this variable, one can try to add the
+following lines in their config file after having load the
+Dracula theme:
+
+ (unless (display-graphic-p)
+ (set-face-background 'default \"black\" nil))
+
+There is a lot of discussion behind the 256 colors theme (see URL
+`https://github.com/dracula/emacs/pull/57'). Please take time to
+read it before opening a new issue about your will.")
;;;; Theme definition:
- [nongnu] elpa/dracula-theme 5eb9e7b 114/187: Less intrusive flyspell decoration, (continued)
- [nongnu] elpa/dracula-theme 5eb9e7b 114/187: Less intrusive flyspell decoration, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme 28b6ef8 118/187: Use whitebright as fg color in terms and try to improve lazy-highlight, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme 499a4d3 117/187: Use a more readable color for comment in 256 colors, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme 42d0ad3 120/187: Reformat README file, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme fcb9add 122/187: Merge branch 'ed-test-term-colors', ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme a59f773 123/187: Allow the use of a custom emacs bin in start_emacs_test.sh, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme ed2f68d 124/187: Improve tab-bar and tab-line colors, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme 7751d4d 135/187: Bump version, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme 4505d0b 131/187: Pinkify completions-first-difference, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme f11979b 132/187: Align markdown-mode on org-mode, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme e4672e2 137/187: Do not advertize dracula-use-24-bit-colors-on-256-colors-terms in README,
ELPA Syncer <=
- [nongnu] elpa/dracula-theme 12e2b3a 140/187: [DOCS] Update Homebrew Formulae to be correct, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme fea2f54 141/187: Merge pull request #61 from mattclegg/patch-1, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme 11391ea 142/187: Try a new 256 colors palette, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme 1ae8236 144/187: Merge branch 'new-256', ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme e375b6f 153/187: Merge branch 'add-lsp-ui', ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme 17cf5f0 162/187: Merge branch 'kekeimiku-master', ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme e559624 148/187: Fix speedbar-highlight-face and add speedbar-separator-face, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme 597d5da 150/187: Add faces hardcoded by lsp-ui, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme 4c88947 155/187: Complete support of message, ELPA Syncer, 2021/10/21
- [nongnu] elpa/dracula-theme f98f9bd 157/187: Improve a little test script, ELPA Syncer, 2021/10/21