emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/popup 38156f0 182/184: Don’t use ‘mapcar’ for side effect


From: ELPA Syncer
Subject: [nongnu] elpa/popup 38156f0 182/184: Don’t use ‘mapcar’ for side effect
Date: Wed, 6 Oct 2021 00:01:39 -0400 (EDT)

branch: elpa/popup
commit 38156f027a31b305b49dcce8da70a5d86a0ab8eb
Author: Philipp Stephani <phst@google.com>
Commit: Philipp Stephani <phst@google.com>

    Don’t use ‘mapcar’ for side effect
---
 popup.el | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/popup.el b/popup.el
index 4fee3ac..49a7052 100644
--- a/popup.el
+++ b/popup.el
@@ -245,11 +245,11 @@ ITEM is not string."
 Optional argument REP is the replacement string of non-displayable character."
   (unless rep (setq rep ""))
   (let ((result ""))
-    (mapcar (lambda (ch)
-              (setq result (concat result
-                                   (if (char-displayable-p ch) (string ch)
-                                     rep))))
-            str)
+    (mapc (lambda (ch)
+            (setq result (concat result
+                                 (if (char-displayable-p ch) (string ch)
+                                   rep))))
+          str)
     result))
 
 (cl-defun popup-make-item (name



reply via email to

[Prev in Thread] Current Thread [Next in Thread]