Re: Adding more tags for SHR

[Lars Ingebrigtsen]

Jeremy Friesen <jeremy.n.friesen@gmail.com> writes:

> Attached is a patch for more rendering options for SHR.

Thanks; looks great!

A couple very minor comments:

> +(defcustom shr-before-q-tag "“"
> +  "Before quote used for q-tag.

Perhaps it'd be best to default this to nil and then do something along
the lines of

  (shr-insert (or shr-before-q-tag
                  (if (char-displayable-p ?“) ?“ ?\")))

in -tag-q to ensure that the default is displayable everywhere.

> +(defun shr-tag-time (dom)
> +    (when-let* ((datetime (or

Misindented?

This change is larger than what we can apply without getting a copyright
assignment for the FSF.

   https://www.gnu.org/licenses/why-assign.en.html

Are you willing to sign such paperwork?  If so, here's the paperwork to
get started.

Please email the following information to assign@gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]

[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]

[For the copyright registration, what country are you a citizen of?]

[What year were you born?]

[Please write your email address here.]

[Please write your postal address here.]

[Which files have you changed so far, and which new files have you written
so far?]