Re: master 2e090da: Revert commit 1f44a776729adf9c6468a76f8310616fde62eeaa for Flymake.

[Philipp Stephani]

Am So., 25. Okt. 2020 um 14:59 Uhr schrieb Stefan Monnier
<monnier@iro.umontreal.ca>:
>
> >     Revert commit 1f44a776729adf9c6468a76f8310616fde62eeaa for Flymake.
> >     Flymake supports all Emacs versions back to 26.1, so it can’t use
> >     ‘ert-resource-file’.
> >     * test/lisp/progmodes/flymake-tests.el (flymake-tests-data-directory):
> >     Recreate.
> >     (flymake-tests--call-with-fixture): Stop using ‘ert-resource-file’.
>
> It's common for a package to say "require Emacs version NN.MM" but to
> provide extra features on more recent Emacsen.  And the tests can
> definitely fall into the category of extra features.
>

I disagree, the tests are a core part of the code, and it's crucial
that they can be run against any supported Emacs version. This implies
that the tests themselves need to be compatible with all supported
Emacs versions.
We should really run the tests of such packages against all supported
versions on the CI system to avoid such breakages.