Re: master 9f464cc: Stop using calc for ntlm time computation

[Stefan Monnier]

Mattias Engdegård [2020-10-27 12:33:36] wrote:

> 26 okt. 2020 kl. 22.57 skrev Mattias Engdegård <mattiase@acm.org>:
>
>> However, I don't have access to any 32-bit Emacs, so I would need help for 
>> testing it.
>
> I've pushed a new implementation. Perhaps someone with a 32-bit Emacs < 27.1
> would try it out. Running the test would suffice.

Didn't get there yet.  Here's my latest attempt:

    make EMACS=/usr/bin/emacs MODULES_EMACSOPT="" test/lisp/net/ntlm-tests
    make -C test lisp/net/ntlm-tests
    make[1] : on entre dans le répertoire « /home/monnier/src/emacs/trunk/test »
    make[2] : on entre dans le répertoire « /home/monnier/src/emacs/trunk/test »
      ELC      lisp/net/ntlm-tests.elc
    
    In end of data:
    lisp/net/ntlm-tests.el:53:1:Warning: the function ‘ntlm--time-to-timestamp’ 
is
        not known to be defined.
      GEN      lisp/net/ntlm-tests.log
    Running 1 tests (2020-10-27 09:05:13-0400)
    Test ntlm-time-to-timestamp backtrace:
      signal(void-function (ntlm--time-to-timestamp))
      apply(signal (void-function (ntlm--time-to-timestamp)))
      (setq value-2 (apply fn-0 args-1))
      (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-descri
      (if (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-de
      (let (form-description-4) (if (unwind-protect (setq value-2 (apply f
      (let ((value-2 (quote ert-form-evaluation-aborted-3))) (let (form-de
      (let* ((fn-0 (function equal)) (args-1 (condition-case err (let ((si
      (let ((time (quote (24471 63910 412962 0)))) (let* ((fn-0 (function 
      (closure (t) nil (let ((time (quote (24471 63910 412962 0)))) (let* 
      ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
      ert-run-test(#s(ert-test :name ntlm-time-to-timestamp :documentation
      ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable)) 
      ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
      ert-run-tests-batch((not (tag :unstable)))
      ert-run-tests-batch-and-exit((not (tag :unstable)))
      eval((ert-run-tests-batch-and-exit (quote (not (tag :unstable)))))
      command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/ntlm-tests.el" "
      command-line()
      normal-top-level()
    Test ntlm-time-to-timestamp condition:
        (void-function ntlm--time-to-timestamp)
       FAILED  1/1  ntlm-time-to-timestamp
    
    Ran 1 tests, 0 results as expected, 1 unexpected (2020-10-27 09:05:13-0400)
    
    1 unexpected results:
       FAILED  ntlm-time-to-timestamp

Where /usr/bin/emacs is the one from Debian's testing (26.3).


        Stefan