[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [elpa] master 9ef4325: * debbugs-gnu.el (debbugs-gnu--parse-mail): P
From: |
Stefan Monnier |
Subject: |
Re: [elpa] master 9ef4325: * debbugs-gnu.el (debbugs-gnu--parse-mail): Pacify byte compiler. |
Date: |
Sun, 11 Oct 2020 09:27:19 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> diff --git a/packages/debbugs/debbugs-gnu.el b/packages/debbugs/debbugs-gnu.el
> index 5084b61..ceddc00 100644
> --- a/packages/debbugs/debbugs-gnu.el
> +++ b/packages/debbugs/debbugs-gnu.el
> @@ -2680,6 +2680,9 @@ If SELECTIVELY, query the user before applying the
> patch."
> (defun debbugs-gnu--parse-mail (string)
> (let* ((mail-extr-ignore-single-names nil)
> (mail-extr-ignore-realname-equals-mailbox-name nil))
> + ;; Pacify byte compiler.
> + (ignore
> + mail-extr-ignore-single-names
> mail-extr-ignore-realname-equals-mailbox-name)
> (mail-extract-address-components string)))
>
I suspect this is wrong because the warnings here reflects a real bug.
The bug is that those variables should not be bound lexically but
dynamically, so the real fix is to add
(defvar mail-extr-ignore-single-names)
(defvar mail-extr-ignore-realname-equals-mailbox-name)
somewhere earlier, or to `require` the package which defines those two vars.
Stefan
- Re: [elpa] master 9ef4325: * debbugs-gnu.el (debbugs-gnu--parse-mail): Pacify byte compiler.,
Stefan Monnier <=