Re: master baf331e 3/3: Rename replace-in-string to string-replace

[Mattias Engdegård]

28 sep. 2020 kl. 17.42 skrev Robert Pluim <rpluim@gmail.com>:

> Yes, itʼs an unfortunate clash. Then again, how much XEmacs code still
> exists that depends on it?

In the Emacs tree, prolog-mode used replace-in-string for regexp-matching 
replacement. This was taken as an indication that repurposing that name would 
have been risky.

The change of names may have been wise or unnecessarily prudent; I haven't 
found any other use of replace-in-string in the wild that isn't explicitly 
guarded by a test for XEmacs. Nevertheless, 'string-replace' isn't a bad name.