[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Move 'with-buffer-modified-unmodified' to simple.el
From: |
Stefan Monnier |
Subject: |
Re: Move 'with-buffer-modified-unmodified' to simple.el |
Date: |
Wed, 16 Sep 2020 23:11:47 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> Currently it’s in bookmark.el. It seems to make more sense to be in
> simple.el or sub.el. WDYT?
Most use cases should be covered by `with-silent-modifications`, but
there might indeed be cases as in bookmark.el where the extra bindings
in `with-silent-modifications` aren't right.
Could you look through our code (e.g. with something like
grep '(set-buffer-modified-p' **/*.el | grep -v 'd-p \(nil\|t\))'
) to see where we could use `with-silent-modifications` and where only
'with-buffer-modified-unmodified' can be used?
Stefan