Re: A modern-mode?

[Andrea Corallo]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Hi Andrea,
>
> Any chance you could turn it into a custom-theme?
>
> AFAIK most of your minor-mode could be turned into a theme fairly
> easily, so what I'm asking is for you try and do the extra work to cover
> the remaining non-trivial part (e.g. the key-bindings).
>
> Part of the difference between a minor mode and a custom theme is that
> a custom theme is more declarative, with consequences such as the fact
> that a user can enable your hypothetical "modern theme" but with
> `fido-mode` disabled, and it won't have the effect of "enabling and then
> disabling" `fido-mode` (e.g. running `fido-mode-hook` twice along the
> way).

Sounds like is what we want.  Happy to have a look into this direction.

> I'm mostly interested in pushing the limits of what can be done with
> custom themes, so try to keep an eye on what generic/infrastructure
> changes would make a "modern theme" easier to write cleanly.
>
>> I had a look but for now I gave-up on the idea of picking up a dark mode
>> to enable as is not so easy.
>
> I thought setting the foreground and the background of the `default`
> face  is all it takes (it should change the frame-background-mode and
> thus cause all other faces to choose their dark-background alternative).
> What problem did you encounter?

Sorry I wasn't clear, I was not referring to a technical difficulty.

All I did was just having a look to the dark themes we have in Emacs
core and could not find one that fully convinced me.  Wombat and
tango-dark are not bad but modus-vivendi has maybe the best set of
colors, OTOH I think this last IMO has a little too much contrast
(probably because focus on accessibility).

One thing I noticed is that tool and scroll bar don't change color (I'm
testing with GTK).  If this an Emacs limitation is not very good as the
aesthetic outcome with a dark theme IMO is not optimal (say pretty bad).

That said I think this should enable some dark setting so I'll look into
how to proceed (suggestions very welcome on this too :).

  Andrea