Re: [PATCH] Add gv-define-expander for plist-get

[Naoya Yamashita]

> Looks like I was just confused, thanks for double checking.

OK, your welcome (and my patch is mistaken same issue)

>>                     `(cadr ,p)
>                        ^^^^
>                        car?

Thanks. I change this code repeatedly and squash many time,

I was confused at that time.

> Could you send me the patch against `master`, so I can install it?

OK, I recreated the patch and attached it.

2020年9月9日(水) 12:23 Stefan Monnier <monnier@iro.umontreal.ca>:

> I cannot understand this point.  Your additional test is passed
> by current code, the additional quote is unneeded I think.

Looks like I was just confused, thanks for double checking.

>    (lambda (do plist prop)
>      (macroexp-let2 macroexp-copyable-p key prop
>        (gv-letplace (getter setter) plist
> -        (macroexp-let2 nil p `(plist-member ,getter ,key)
> +        (macroexp-let2 nil p `(cdr (plist-member ,getter ',key))
>            (funcall do
>                     `(cadr ,p)
                        ^^^^
                        car?

Could you send me the patch against `master`, so I can install it?


        Stefan

0001-Add-gv-define-expander-for-plist-get.patch
Description: Text Data