[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin
From: |
Andrii Kolomoiets |
Subject: |
Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188) |
Date: |
Sat, 05 Sep 2020 22:34:00 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> - (ewoc-invalidate vc-ewoc node))
>> + ;; `ewoc-invalidate' will kill line and insert new
>> text,
>> + ;; let's keep point column.
>> + (let ((p (point)))
>> + (ewoc-invalidate vc-ewoc node)
>> + (goto-char p)))
>
> Shouldn't this be done in `ewoc-invalidate` instead?
Good point! According 'ewoc-invalidate' docstring, refreshing is done
by deleting the text and inserting the new one thus the 'save-excursion'
is not really helpful.
Please see attached patch.
0001-Save-and-restore-point-in-ewoc-invalidate.patch
Description: Text Data
- Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188), Stefan Monnier, 2020/09/04
- Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188),
Andrii Kolomoiets <=
- Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188), Stefan Monnier, 2020/09/05
- Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188), Andrii Kolomoiets, 2020/09/13
- Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188), Stefan Monnier, 2020/09/13
- Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188), Andrii Kolomoiets, 2020/09/15
- Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188), Stefan Monnier, 2020/09/15
- Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188), Andrii Kolomoiets, 2020/09/18
- Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188), Stefan Monnier, 2020/09/18
- Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188), Andrii Kolomoiets, 2020/09/18
- Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188), Stefan Monnier, 2020/09/18
- Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188), Andrii Kolomoiets, 2020/09/24