Re: master 6e70b37: When decrypting non-decrypted files, make epa show the raw files

[Herbert J. Skuhra]

On Sun, Aug 23, 2020 at 10:54:27PM +0200, Herbert J. Skuhra wrote:
> On Tue, 04 Aug 2020 21:43:03 +0200, larsi@gnus.org wrote:
> > 
> > branch: master
> > commit 6e70b3793b9cb7730ab8a7132aa6e99f1ca13f98
> > Author: Lars Ingebrigtsen <larsi@gnus.org>
> > Commit: Lars Ingebrigtsen <larsi@gnus.org>
> > 
> >     When decrypting non-decrypted files, make epa show the raw files
> >     
> >     * lisp/epa-file.el (epa-file-insert-file-contents): When trying to
> >     decrypt a non-decrypted file, just show the bytes from the file
> >     instead (bug#3829).
> 
> After this commit running 'C-x C-f ~/newfile.gpg' produces an error:
> 
> epa-file-insert-file-contents: Wrong type argument: char-or-string-p, nil
> 
> Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil)
>   epa-file-decode-and-insert(nil "/home/herbert/newfile.gpg" t nil nil nil)
>   epa-file-insert-file-contents("/home/herbert/newfile.gpg" t nil nil nil)
>   apply(epa-file-insert-file-contents ("/home/herbert/newfile.gpg" t nil nil 
> nil))
>   epa-file-handler(insert-file-contents "/home/herbert/newfile.gpg" t nil nil 
> nil)
>   insert-file-contents("~/newfile.gpg" t)
>   find-file-noselect-1(#<buffer newfile.gpg> "~/newfile.gpg" nil nil 
> "~/newfile.gpg" nil)
>   find-file-noselect("~/newfile.gpg" nil nil t)
>   find-file("~/newfile.gpg" t)
>   funcall-interactively(find-file "~/newfile.gpg" t)
>   call-interactively(find-file nil nil)
>   command-execute(find-file)
>   
> If I run the command 'find-file' again it works.

But I am not asked to select a gpg key ... only symmetric encryption is
offered!

There is obviously another bug (but unrelated to this commit):

If I revert the above commit and try to create and save an encrypted
file I get: 

Select recipients for encryption.
If no one is selected, symmetric encryption will be performed.  
- ‘m’ to mark a key on the line
- ‘u’ to unmark a key on the line
[Cancel][OK]


How do you proceed with symmetric encryption? Just pressing OK without
selecting a key does not work.

-- 
Herbert