Re: master a539488: Always make a multibyte string for the frame title (bug#42904)

[Lars Ingebrigtsen]

Mattias Engdegård <mattiase@savannah.gnu.org> writes:

>     Always make a multibyte string for the frame title (bug#42904)
>
>     * src/xdisp.c (gui_consider_frame_title): Multibyte-encode any raw
>     bytes in the title, and then pass a multibyte string to the back-end
>     for use as a frame title.  This cuts down a little on the rubbish
>     shown when raw bytes sneak in by mistake (as part of the buffer name,
>     for instance).

This is giving me some compilation warnings on Debian:

xdisp.c: In function ‘gui_consider_frame_title’:
xdisp.c:12571:31: warning: pointer targets in passing argument 1 of 
‘str_as_multibyte’ differ in signedness [-Wpointer-sign]
12571 |       len = str_as_multibyte (title, mode_line_noprop_buf_end - title,
      |                               ^~~~~
      |                               |
      |                               char *
In file included from dispextern.h:25,
                 from composite.h:29,
                 from xdisp.c:441:
character.h:226:36: note: expected ‘unsigned char *’ but argument is of type 
‘char *’
  226 | CHAR_STRING (int c, unsigned char *p)
      |                     ~~~~~~~~~~~~~~~^


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no