emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master b8062be 3/5: Remove some compat code from eudc-bob.el


From: Eli Zaretskii
Subject: Re: master b8062be 3/5: Remove some compat code from eudc-bob.el
Date: Fri, 14 Aug 2020 09:05:00 +0300

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Thu, 13 Aug 2020 15:54:43 -0400
> 
> >> >> > In unibyte buffers the coding-system doesn't matter.
> >> > Again, this factoid isn't relevant to the issue at hand.
> >> Not sure what is the issue at hand at this point
> > The code in eudc-bob.el, of course.
> 
> In that particular case, I don't know whether the coding-system will
> make a difference because I don't know if the `data` will contain
> newlines and if so whether their encoding is significant.

If newline conversion is the only consideration, we could bind
inhibit-eol-conversion instead, no need for the coding-system stuff.

My point is that code which makes a buffer unibyte and then sets its
buffer-file-coding-system yells "FIXME!", so it is best not to write
it.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]