Re: A question about overlays and performance.

[Ihor Radchenko]

> Any chance to fix also bug#40808? It's still open because there is
> no solution for isearching invisible text in org-mode.

Thanks for pointing out this bug. Searching actually works fine on my
feature branch + patched isearch (though it is actually an unintended
side-effect). However, (setq isearch-lazy-count t) leaves the last
headline open. I will need to investigate this. 

> The problem is that org-mode puts the text property 'invisible'
> only when the link is scrolled into view, I guess it puts the property
> using font-lock.
>
> So it seems org-mode needs to use font-lock-ensure on the line
> with the next search hit before calling isearch-filter-predicate
> on the found occurence.

I am currently undecided about searchability of hidden text in links. Do
I understand correctly that you prefer the hidden parts of links to be
searchable? Either way is possible. If hidden parts are searchable, it
will be even possible to show them temporarily.

Best,
Ihor


Juri Linkov <juri@linkov.net> writes:

>> I am currently working on re-implementing org-mode folding from using
>> overlays to text-properties.
>
> Any chance to fix also bug#40808? It's still open because there is
> no solution for isearching invisible text in org-mode.
>
> Here's a short test case that demonstrates the problem in org-mode:
>
> 0. emacs -Q
> 1. visit emacs/etc/ORG-NEWS
> 2. isearch for "http": C-s http C-s C-s C-s ...
>
> it eventually stops at org links where "http" is invisible, such as
>
>   [[https://orgmode.org/worg/library-of-babel.html][here]]
>
> The problem is that org-mode puts the text property 'invisible'
> only when the link is scrolled into view, I guess it puts the property
> using font-lock.
>
> So it seems org-mode needs to use font-lock-ensure on the line
> with the next search hit before calling isearch-filter-predicate
> on the found occurence.

-- 
Ihor Radchenko,
PhD,
Center for Advancing Materials Performance from the Nanoscale (CAMP-nano)
State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong 
University, Xi'an, China
Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg