emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: message logging (*Messages*)


From: Miles Bader
Subject: Re: message logging (*Messages*)
Date: Fri, 17 Nov 2000 13:33:57 +0900 (JST)

Emboldened by flattery, I investigated further ... and found that
there's already code to do something similar (it's slightly different,
in that it only merges messages with "..." in them, and in fact ignores
anything following the dots for the purpose of comparison) -- but it
doesn't work in the overwhelmingly common case, where the first message
ends with "..."!

I don't know if this is intentional, or a bug, but the following
one-line patch makes it work the way I think it should:

diff -uwBp src/xdisp.c.\~7\~ src/xdisp.c
--- src/xdisp.c.~7~     Thu Nov 16 15:17:33 2000
+++ src/xdisp.c Fri Nov 17 13:17:47 2000
@@ -5356,8 +5356,7 @@ message_log_check_duplicate (prev_bol, p
 
   for (i = 0; i < len; i++)
     {
-      if (i >= 3 && p1[i-3] == '.' && p1[i-2] == '.' && p1[i-1] == '.'
-         && p1[i] != '\n')
+      if (i >= 3 && p1[i-3] == '.' && p1[i-2] == '.' && p1[i-1] == '.')
        seen_dots = 1;
       if (p1[i] != p2[i])
        return seen_dots;

Gerd, can you comment on whether there's some reason why this code
ignored messages ending with "..." before?

-Miles
-- 
Love is a snowmobile racing across the tundra.  Suddenly it flips over,
pinning you underneath.  At night the ice weasels come.  --Nietzsche



reply via email to

[Prev in Thread] Current Thread [Next in Thread]