Re: make-variable-buffer-local vs. make-local-variable

[Noah Friedman]

>I'm curious if there's any concensus over which is a better way to
>define (purely) buffer-local variables for a mode --
>
>  (defvar foo-bar ...)
>  (make-variable-buffer-local 'foo-bar)
>  (defun foo-mode ()
>    (setq foo-bar ...))
>
>or
>
>  (defvar foo-bar ...)
>  (defun foo-mode ()
>    (set (make-local-variable 'foo-bar) ...))

Certainly the former is always correct for user options, but since the
modern convention for those is to use defcustom I assume you were only
talking about "internal" variables.

Even in that case I prefer the former because it's more explicit that
anywhere the variable is modified it will already be buffer-local.  The
boundaries between packages are not always very clear.  For example I've
written several major modes on top of other major modes but I do not
necessarily want to invoke the parent mode's "foo-mode" function.