Re: (type graphic)

[Miles Bader]

"Eli Zaretskii" <address@hidden> writes:
> The net effect is that the new code causes the tty colors to be used
> for the MS-DOS port, whereas previously it used the X colors
> (approximated by tty-colors.el).

Why?  The old code was basically the same, but just tested that
`window-system' was nil to identify ttys.  Does the MS-DOS port have a
non-nil value of window-system?

If so, maybe the correct change for right now is to replace
`(display-graphic-p FRAME)' with just `window-system', and it will
revert to the old behavior.  More importantly, leave in `type graphic',
but make a note that the graphic/tty distinction is broken on MS-DOS.

Actually, perhaps a better way would something like:

            match (cond ((eq req 'type)
                         (or (memq window-system options)
                             (cond ((display-graphic-p frame)
                                    (memq 'graphic options))
                                   ((null window-system)
                                    (memq 'tty options))
                                   (t
                                    ;; no-mans land, e.g., `pc'
                                    nil)))))

[meaning `pc' is *neither* a graphic  display or a tty; correct?]

And then do option (3) for 21.2.

>   3) Replace (type tty) with (type 8-color), or with some other magic
>      that looks at the number of the supported colors.

[Such a distinction should be on the `(color ...)' tag, not the type tag.]

-Miles
-- 
Love is a snowmobile racing across the tundra.  Suddenly it flips over,
pinning you underneath.  At night the ice weasels come.  --Nietzsche