bug#63159: closed ([PATCH 1/2] gnu: slim: Fix build failure with GCC-11)

[GNU bug Tracking System]

Your message dated Sun, 30 Apr 2023 23:16:33 +0200
with message-id <875y9doytq.fsf@gnu.org>
and subject line Re: bug#63159: [PATCH 1/2] gnu: slim: Fix build failure with 
GCC-11
has caused the debbugs.gnu.org bug report #63159,
regarding [PATCH 1/2] gnu: slim: Fix build failure with GCC-11
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63159: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63159
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 1/2] gnu: slim: Fix build failure with GCC-11
>
>
>
>
> Date: 
>
> Fri, 28 Apr 2023 17:25:22 -0400
>
>
>
>
> GCC-11 sniffed out a long-standing bug where a pointer was being tested for a
> negative value, which is impossible. Instead, check for NULL, which is how the
> error result is actually returned.
>
> See https://github.com/iwamatsu/slim/issues/14 for details.
>
> * gnu/packages/display-managers.scm (slim) [fix-0-pointer-comparison]: new
> phase
> ---
>  gnu/packages/display-managers.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/display-managers.scm 
> b/gnu/packages/display-managers.scm
> index b0d388f1bc..c1a08e8553 100644
> --- a/gnu/packages/display-managers.scm
> +++ b/gnu/packages/display-managers.scm
> @@ -475,7 +475,11 @@ (define-public slim
>                 ;; The build system's logic here is: if "Linux", then
>                  ;; "systemd".  Strip that.
>                  ""))
> -             #t)))
> +             #t))
> +         (add-before 'configure 'fix-0-pointer-comparison
> +           (lambda _
> +             (substitute* "panel.cpp"
> +               (("WinGC < 0") "WinGC == NULL")))))
>         #:configure-flags '("-DUSE_PAM=yes"
>                             "-DUSE_CONSOLEKIT=no")
>         #:tests? #f))
> -- 
> 2.39.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#63159: [PATCH 1/2] gnu: slim: Fix build failure with GCC-11
>
>
>
>
> Date: 
>
> Sun, 30 Apr 2023 23:16:33 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Brian Cully <bjc@spork.org> skribis:
>
> > GCC-11 sniffed out a long-standing bug where a pointer was being tested for a
> > negative value, which is impossible. Instead, check for NULL, which is how the
> > error result is actually returned.
> >
> > See https://github.com/iwamatsu/slim/issues/14 for details.
> >
> > * gnu/packages/display-managers.scm (slim) [fix-0-pointer-comparison]: new
> > phase
>
> [...]
>
> > Moved to github, according to https://www.berlios.de/software/slim/.
> >
> > * gnu/packages/display-managers.scm (slim) [home-page]:  update URL.
>
> Applied, thanks!
>
> Ludo’.
>
>
> --- End Message ---