bug#63155: closed (slim fails to build)

[GNU bug Tracking System]

Your message dated Sun, 30 Apr 2023 23:16:33 +0200
with message-id <875y9doytq.fsf@gnu.org>
and subject line Re: bug#63159: [PATCH 1/2] gnu: slim: Fix build failure with 
GCC-11
has caused the debbugs.gnu.org bug report #63155,
regarding slim fails to build
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63155: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63155
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> slim fails to build
>
>
>
>
> Date: 
>
> Fri, 28 Apr 2023 21:23:16 +0200
>
>
>
>
> User-agent: 
>
> mu4e 1.10.2; emacs 29.0.90
>
>
>
>
>
> compilation error is:
>
> /tmp/guix-build-slim-1.3.6.drv-0/slim-1.3.6/panel.cpp: In 
> constructor ‘Panel::Panel(Display*, int, Window, Cfg*, const 
> string&, Panel::PanelType)’:
> /tmp/guix-build-slim-1.3.6.drv-0/slim-1.3.6/panel.cpp:51:27: 
> error: ordered comparison of pointer with integer zero (‘GC’ {aka 
> ‘_XGC*’} and ‘int’)
>   51 |                 if (WinGC < 0) {
>      |                     ~~~~~~^~~
> make[2]: *** [CMakeFiles/libslim.dir/build.make:121: 
> CMakeFiles/libslim.dir/panel.cpp.o] Error 1
>
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#63159: [PATCH 1/2] gnu: slim: Fix build failure with GCC-11
>
>
>
>
> Date: 
>
> Sun, 30 Apr 2023 23:16:33 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Brian Cully <bjc@spork.org> skribis:
>
> > GCC-11 sniffed out a long-standing bug where a pointer was being tested for a
> > negative value, which is impossible. Instead, check for NULL, which is how the
> > error result is actually returned.
> >
> > See https://github.com/iwamatsu/slim/issues/14 for details.
> >
> > * gnu/packages/display-managers.scm (slim) [fix-0-pointer-comparison]: new
> > phase
>
> [...]
>
> > Moved to github, according to https://www.berlios.de/software/slim/.
> >
> > * gnu/packages/display-managers.scm (slim) [home-page]:  update URL.
>
> Applied, thanks!
>
> Ludo’.
>
>
> --- End Message ---