bug#62734: closed (Always fully rebuild autoloads in package-generate-autoloads)

[GNU bug Tracking System]

Your message dated Sun, 30 Apr 2023 16:45:12 +0000
with message-id <87wn1tuxnr.fsf@posteo.net>
and subject line Re: bug#62734: Always fully rebuild autoloads in 
package-generate-autoloads
has caused the debbugs.gnu.org bug report #62734,
regarding Always fully rebuild autoloads in package-generate-autoloads
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
62734: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62734
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: Always fully rebuild autoloads in package-generate-autoloads Date: Sat, 08 Apr 2023 23:16:23 +0200

Tags: patch

Hello!

I've been using the new package-vc.el functionality to great effect,
but I have also come across a somewhat annoying bug.  If I use any of
the provided commands to rebuild my local package while a autoloads
file is already present, the newly generated autoloads file is
consistently either incomplete or empty.

The easiest way I've found to fix this is simply changing the
`package-generate-autoloads' function to always rebuild the autoloads
file by passing the relevant option to `loaddefs-generate'.  I think
this change also makes sense on a larger scale, as package generation
taking into account older build artifacts seems unintuitive.

The attached patch implements this change.

I've read that for small changes like this no copyright assignment
is needed.  If I have misunderstood, please point me to the relevant
documents so I can sign them.  Please also let me know if I have
messed something up or you need any additional information.


Best wishes

Leo Gaskin


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.16.0, Xaw3d scroll bars)
Repository revision: 9848ae17161828190cc0ba31e89ae54a2f08a2ef
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101008
System Description: NixOS 23.05 (Stoat)

Configured using:
 'configure
 --prefix=/nix/store/y9bxk3kqk4isr28jcy1bclkdr5a4zd1v-emacs-git-20230407.0
 --disable-build-details --with-modules --with-x-toolkit=lucid
 --with-xft --with-cairo --with-native-compilation'

0001-Always-fully-rebuild-autoloads-in-package-generate-a.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#62734: Always fully rebuild autoloads in package-generate-autoloads
>
>
>
>
> Date: 
>
> Sun, 30 Apr 2023 16:45:12 +0000
>
>
>
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Philip Kaludercic <philipk@posteo.net>
> >> Cc: leo.gaskin@le0.gs,  62734@debbugs.gnu.org
> >> Date: Sun, 30 Apr 2023 09:17:16 +0000
> >> 
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >> 
> >> >> > What happens if a package has no autoloads?  The doc string says in
> >> >> > that case passing EXTRA-DATA will produce OUTPUT-FILE regardless.
> >> >> > Does your patch handle that?  (It's hard to tell, given all the
> >> >> > whitespace changes in the patch.)
> >> >> 
> >> >> It would, as the else-case of the if branch I am proposing to eliminate
> >> >> would still insert the EXTRA-DATA.
> >> >
> >> > And if EXTRA-DATA is nil, then will we generate an empty OUTPUT file?
> >> 
> >> No, we still generate the right file with the right information (in this
> >> case just a `register-definition-prefixes' invocation).
> >
> > OK, thanks.  Then please make sure this change survives both a
> > bootstrap and a "normal" build (where a bunch of *.el files need their
> > autoloads updated), and if so, please install on the emacs-29 branch.
>
> Done, I have been testing it for a better part of the day and from what
> I saw all behaved the way it should.
>
> Thanks to Leo for noticing the problem in the first place, package-vc
> also appears to be doing the right thing now.
>
>
> --- End Message ---