emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#62708: closed ([PATCH] Add option to control default outlining in C-


From: GNU bug Tracking System
Subject: bug#62708: closed ([PATCH] Add option to control default outlining in C-h b)
Date: Mon, 24 Apr 2023 11:44:02 +0000

Your message dated Mon, 24 Apr 2023 14:43:49 +0300
with message-id <83ildly07e.fsf@gnu.org>
and subject line Re: bug#62708: [PATCH] Add option to control default outlining 
in C-h b
has caused the debbugs.gnu.org bug report #62708,
regarding [PATCH] Add option to control default outlining in C-h b
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
62708: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62708
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] Add option to control default outlining in C-h b Date: Fri, 07 Apr 2023 13:37:56 +0300
Tags: patch

Hi,

The attached patch adds a user option `describe-bindings-outline-rules`
that is used in `describe-bindings` to as the local value of
`outline-default-rules`.  This replaces a currently hard-coded setting
that takes care of hiding "Key translations" to give users more control.
For example, to also have `pixel-scroll-precision-mode` bindings
initially hidden, one can set this option to:

'((match-regexp . "Key translations\\|pixel-scroll-precision-mode"))



In GNU Emacs 30.0.50 (build 1, x86_64-apple-darwin22.4.0, NS
 appkit-2299.50 Version 13.3 (Build 22E252)) of 2023-04-06 built on
 esmac
Repository revision: 5e5f5b28e92a3bb927bb03c783c426c6c3baeadc
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2299
System Description:  macOS 13.3

Configured using:
 'configure CFLAGS=-O3 --with-native-compilation --with-json
 --with-tree-sitter'

Attachment: 0001-Add-option-to-control-default-outlining-in-C-h-b.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#62708: [PATCH] Add option to control default outlining in C-h b Date: Mon, 24 Apr 2023 14:43:49 +0300
> From: Juri Linkov <juri@linkov.net>
> Cc: Eshel Yaron <me@eshelyaron.com>,  62708@debbugs.gnu.org
> Date: Sun, 23 Apr 2023 19:35:01 +0300
> 
> >> FYI I've received confirmation that my copyright assignment is done, so
> >> hopefully that's no longer an issue.
> >
> > Right.
> >
> >> Any comments about the patch itself?
> >
> > Juri, any comments, or should I install it?
> 
> It's nice that the patch makes the currently hard-coded setting
> customizable.  Usually we strive to reduce the number of user options,
> but here I see no other easy way to make this setting customizable
> because there is no hook run from this command where the users
> could override the default outline settings.

Thanks, installed on master, and closing the bug.

Yaron, please in the future observe our conventions for commit log
messages (I made the few minor changes they needed this time).


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]