--- Begin Message ---
|
Subject: |
28.2; VC: CVS: Fix lost file reporting and enable reverting it |
|
Date: |
Thu, 06 Apr 2023 11:51:48 +0200 |
Hi,
When using CVS 1.12.3+, VC dir doesn't list correctly some missing file,
including quotes produced by CVS in the file name, then preventing to operate
on it. The fix works on all "recent" versions of CVS (1.11 and 1.12).
Once this is fixed, it's still not possible to revert such a file yet since
`vc-default-revert', called by `vc-cvs-revert', tries to backup the
non-existing file (`copy-file' just fails).
While here, fixed `vc-cvs-parse-root', which is not correctly reporting whether
some repository is local.
All three patches can be applied to 'master' directly (e579c9cc33d).
Regards.
--
Olivier Certner
0001-VC-CVS-Fix-ROOT-file-parsing.patch
Description: Text Data
0002-VC-CVS-Fix-parsing-of-cvs-qn-update-for-missing-file.patch
Description: Text Data
0003-VC-Allow-vc-default-revert-and-CVS-to-revert-a-missi.patch
Description: Text Data
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#62693: 28.2; VC: CVS: Fix lost file reporting and enable reverting it |
|
Date: |
Wed, 19 Apr 2023 03:54:15 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 |
Version: 30.1
On 17/04/2023 12:24, Olivier Certner wrote:
Regarding the new patch, it's great to see the list of examples, but
could you instead move it to a test or several inside
test/lisp/vc/vc-cvs-tests.el? This file does not exist yet, but you can
use vc-git-test.el as an example, in the same directory.
Yes, having a test for this would be most welcome.
The examples in the commit messages have been removed and replaced by a test
file.
New patch attached. The only new functional change is to test for an empty
hostname in `vc-cvs-repository-hostname', in an attempt to make it easier for
you to see that nothing can be broken as long as `vc-cvs-parse-root' works
correctly. Compared to the old code, the new implementation can, on an
*invalid* CVS/Root specifications, return an empty hostname where the older
would return nil (assuming a correct parsing case). This has no real practical
consequences since 'cvs' commands are anyway bound to fail at a later point in
such a case, but may reassure you about the innocuity of this change.
Very good, I've pushed the three patches to 'master'.
Thank you for your work, and closing.
--- End Message ---