bug#62653: closed ([PATCH] gnu: emacs-eat: Patch ncurses tic executable.)

[GNU bug Tracking System]

Your message dated Tue, 04 Apr 2023 22:18:14 +0200
with message-id <871qkzo0zd.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#62653] [PATCH] gnu: emacs-eat: Patch ncurses tic 
executable.
has caused the debbugs.gnu.org bug report #62653,
regarding [PATCH] gnu: emacs-eat: Patch ncurses tic executable.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
62653: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62653
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: emacs-eat: Patch ncurses tic executable.
>
>
>
>
> Date: 
>
> Mon,  3 Apr 2023 14:49:24 -0500
>
>
>
>
> * gnu/packages/emacs-xyz.scm (arguments): Patch tic executable.
> ---
>
> Reading the code now I found that there's a function that makes a call
> to tic from the ncurses package so I patched it.
>
> all best,
>
> jgart
>
>  gnu/packages/emacs-xyz.scm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index b4edc680ba..9db8a07331 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -27981,7 +27981,14 @@ (define-public emacs-eat
>                (invoke "make" "info")))
>            (add-before 'install 'build-terminfo-database
>              (lambda _
> -              (invoke "make" "terminfo"))))))
> +              (invoke "make" "terminfo")))
> +          (add-before 'install 'patch-ncurses-tic-executable
> +            (lambda* (#:key inputs #:allow-other-keys)
> +              (substitute*
> +                "eat.el"
> +                (("\"tic")
> +                 (string-append "\""
> +                                (search-input-file inputs "/bin/tic")))))))))
>      (native-inputs
>       (list ncurses texinfo))
>      (home-page "https://codeberg.org/akib/emacs-eat";)
> -- 
> 2.39.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#62653] [PATCH] gnu: emacs-eat: Patch ncurses tic executable.
>
>
>
>
> Date: 
>
> Tue, 04 Apr 2023 22:18:14 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hello,
>
> jgart via Guix-patches via <guix-patches@gnu.org> writes:
>
> > * gnu/packages/emacs-xyz.scm (arguments): Patch tic executable.
> > ---
> >
> > Reading the code now I found that there's a function that makes a call
> > to tic from the ncurses package so I patched it.
>
> Good catch!
>
> I also moved ncurses into inputs, otherwise the executable could
> be GC'ed at some point.
>
> Applied. Thank you.
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---