bug#62609: closed (29.0.60; [PATCH] src/comp.c: New variable `comp-el-to-eln-strip-prefix` for `comp-el-to-eln-rel-filename`)

[GNU bug Tracking System]

Your message dated Mon, 03 Apr 2023 17:37:26 +0300
with message-id <83pm8luj4p.fsf@gnu.org>
and subject line Re: 29.0.60; [PATCH] src/comp.c: New variable 
`comp-el-to-eln-strip-prefix` for `comp-el-to-eln-rel-filename`
has caused the debbugs.gnu.org bug report #62609,
regarding 29.0.60; [PATCH] src/comp.c: New variable 
`comp-el-to-eln-strip-prefix` for `comp-el-to-eln-rel-filename`
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
62609: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62609
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 29.0.60; [PATCH] src/comp.c: New variable `comp-el-to-eln-strip-prefix` for `comp-el-to-eln-rel-filename` Date: Sun, 2 Apr 2023 05:13:28 +0000

Hi,

The emacs with native compile enabled will always rebuild all the
~/.emacs.d/eln-cache/VER/*.eln files if I moved/copied eln-cache
folder from
/home/userA/.emacs.d/eln-cache/ to
/home/userB/.emacs.d/eln-cache/.

It is caused by the function `comp-el-to-eln-rel-filename` calculating
the hash value from the absolute *.el filename to be the middle of the
eln file name.

The new variable `comp-el-to-eln-strip-prefix` in this patch will
allow moving the eln-cache/ folder without rebuilding *.eln in it.

Please help review this change, Thanks

Best Regards
Lin

0001-New-variable-comp-el-to-eln-strip-prefix-for-comp-el.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: 29.0.60; [PATCH] src/comp.c: New variable `comp-el-to-eln-strip-prefix` for `comp-el-to-eln-rel-filename`
>
>
>
>
> Date: 
>
> Mon, 03 Apr 2023 17:37:26 +0300
>
>
>
>
> tags 62609 wontfix
> thanks
>
> > From: Andrea Corallo <akrl@sdf.org>
> > Cc: lin Sun <sunlin7@yahoo.com>, 62609@debbugs.gnu.org
> > Date: Mon, 03 Apr 2023 14:08:36 +0000
> > 
> > Eli Zaretskii <eliz@gnu.org> writes:
> > 
> > >> From: lin Sun <sunlin7@yahoo.com>
> > >> Date: Mon, 3 Apr 2023 00:53:18 +0000
> > >> 
> > >> You're right, the patch will allow to relocate/copy an elisp source folder 
> > >> from
> > >> /home/userA/.emacs.d/epla/**.el to
> > >> /home/userB/.emacs.d/epla/**.el.
> > >> So the patch should be the
> > >> "0002-New-variable-comp-el-to-eln-strip-prefix-for-comp-el.patch"
> > >> attached in this email.
> > >> 
> > >> And agree with you, it's dangerous when this variable is configured
> > >> with an arbitrary value.
> > >> So please feel free to close this ticket. Thanks
> > >
> > > I'd like to hear what Andrea thinks about this, before I decide
> > > whether to close.
> > 
> > Hi all,
> > 
> > I agree we should not add a new knob in order to move eln-cache without
> > moving the source *.el.  The use-case sounds like a corner case and this
> > new variable would be IMO very sensitive to miss configurations.
>
> OK, so closing.
>
>
> --- End Message ---