bug#62556: closed (29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background)

[GNU bug Tracking System]

Your message dated Sun, 2 Apr 2023 15:09:01 -0700
with message-id <e1061308-16fe-0094-7638-3e73f75dd44e@gmail.com>
and subject line Re: bug#62556: 29.0.60; [PATCH] Fix regression when calling 
'eshell-command' with a pipeline in the background
has caused the debbugs.gnu.org bug report #62556,
regarding 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a 
pipeline in the background
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
62556: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62556
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background Date: Thu, 30 Mar 2023 21:18:10 -0700

Starting from "emacs -Q":

  M-x eshell-command RET *echo hi | *cat & RET

You'll see the following error in the *Messages* buffer instead of the result:

eshell-eval-command: Unmatched delimiter: (#<process echo> . #<process cat>)

This is a regression from my fix for bug#53715, which changed how

Eshell pipelines return the processes in the pipeline. Attached are some patches to fix it. One for the emacs-29 branch, and one for master.

Eli, is it ok to merge the patch for emacs-29? I tried to keep the change as minimal as possible for that branch.

The patch for master is a bit more extensive, and also fixes another issue where this would fail due to incorrect syntax in the Eshell command form:

  (eshell-command "*echo hi &" t)

Previously, it turned the command into "*echo hi & >>> #<current-buffer>", but that's not right; the "&" needs to go last.

For master, I also thought it would be nice to clean up 'eshell-command' slightly (see patch 0002); this just changes it to handle its arguments in the interactive spec.

emacs-29--0001-Fix-using-background-commands-in-eshell-command.patch
Description: Text document

emacs-30--0001-Fix-using-background-commands-in-eshell-command.patch
Description: Text document

emacs-30--0002-Use-the-interactive-spec-to-set-arguments-for-eshell.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#62556: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background
>
>
>
>
> Date: 
>
> Sun, 2 Apr 2023 15:09:01 -0700
>
>
>
>
> On 4/1/2023 10:31 AM, Jim Porter wrote:
> > I'll make sure these issues are addressed in the patches for master and 
> > then push them in a day or so, too.
>
> Pushed to master as 093a360251a. Closing this now.
>
> Hopefully this works on MS-Windows; I think I wrote it in a way where it 
> should behave the same on all platforms. If not, just let me know, and 
> I'll try to fix it.
>
>
>
> --- End Message ---