bug#61871: closed (29.0.60; ruby-mode indentation with destructuring assignment)

[GNU bug Tracking System]

Your message dated Tue, 28 Feb 2023 23:01:57 +0200
with message-id <d38d2d0f-c044-051f-9acd-523041c3d203@yandex.ru>
and subject line Re: bug#61871: 29.0.60; ruby-mode indentation with 
destructuring assignment
has caused the debbugs.gnu.org bug report #61871,
regarding 29.0.60; ruby-mode indentation with destructuring assignment
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61871: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61871
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 29.0.60; ruby-mode indentation with destructuring assignment
>
>
>
>
> Date: 
>
> Tue, 28 Feb 2023 11:17:27 -0500
>
>
>
>
> I found another edge case:
>
> foo, bar = baz.(
>        some_arg
>      )
>
> Should indent to:
>
> foo, bar = baz.(
>   some_arg
> )
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#61871: 29.0.60; ruby-mode indentation with destructuring assignment
>
>
>
>
> Date: 
>
> Tue, 28 Feb 2023 23:01:57 +0200
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1
>
>
>
>
> Version: 29.1
>
> On 28/02/2023 22:00, Aaron Jensen wrote:
> > On Tue, Feb 28, 2023 at 1:37 PM Dmitry Gutov<dgutov@yandex.ru>  wrote:
> > > Hi!
> > >
> > > On 28/02/2023 18:17, Aaron Jensen wrote:
> > > > I found another edge case:
> > > >
> > > > foo, bar = baz.(
> > > >          some_arg
> > > >        )
> > > >
> > > > Should indent to:
> > > >
> > > > foo, bar = baz.(
> > > >     some_arg
> > > > )
> > > Thanks for that. This one is caused by implicit syntax which it
> > > non-trivial for SMIE to handle. ruby-ts-mode, predictably, indents it fine.
> > >
> > > Please try this patch out:
> > >
> > > diff --git a/lisp/progmodes/ruby-mode.el b/lisp/progmodes/ruby-mode.el
> > > index 559b62fef54..beccb8182a7 100644
> > > --- a/lisp/progmodes/ruby-mode.el
> > > +++ b/lisp/progmodes/ruby-mode.el
> > > @@ -916,11 +916,14 @@ ruby-smie-rules
> > >                (smie-indent--hanging-p))
> > >           ruby-indent-level)))
> > >        (`(:before . "=")
> > > -     (save-excursion
> > > -      (and (smie-rule-parent-p " @ ")
> > > -           (goto-char (nth 1 (smie-indent--parent)))
> > > -           (smie-rule-prev-p "def=")
> > > -           (cons 'column (+ (current-column) ruby-indent-level -3)))))
> > > +     (or
> > > +      (save-excursion
> > > +        (and (smie-rule-parent-p " @ ")
> > > +             (goto-char (nth 1 (smie-indent--parent)))
> > > +             (smie-rule-prev-p "def=")
> > > +             (cons 'column (+ (current-column) ruby-indent-level -3))))
> > > +      (and (smie-rule-parent-p ",")
> > > +           (smie-rule-parent))))
> > >        (`(:after . ,(or "?" ":"))
> > >         (if ruby-after-operator-indent
> > >             ruby-indent-level
> > This works for me for this case, thank you.
>
> Thanks for checking! Closing.
>
>
> --- End Message ---