bug#61778: closed (30.0.50; [PATCH] Be more cautious in completing Eshell variable assignments)

[GNU bug Tracking System]

Your message dated Sat, 25 Feb 2023 20:40:41 -0800
with message-id <1a14e813-a192-810e-e235-7b6c34582aaf@gmail.com>
and subject line Re: bug#61778: 30.0.50; [PATCH] Be more cautious in completing 
Eshell variable assignments
has caused the debbugs.gnu.org bug report #61778,
regarding 30.0.50; [PATCH] Be more cautious in completing Eshell variable 
assignments
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61778: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61778
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 30.0.50; [PATCH] Be more cautious in completing Eshell variable assignments Date: Fri, 24 Feb 2023 22:02:14 -0800

X-Debbugs-Cc: monnier@iro.umontreal.ca

Starting from "emacs -Q":

  M-x shell RET
  tar --directory=<TAB>
  ;; Notice that completions only show directories.

  M-x eshell RET
  tar --directory=<TAB>
  ;; Completions include files *and* directories(!)

After quite a bit of digging, I figured out the issue: Eshell was treating "--directory=" as the beginning of a local variable assignment (like when you run "CC=gcc make"). The function 'eshell-complete-variable-assignment' is over-aggressive in identifying local variable assignments, and so it picked this up as a false positive.

Attached is a fix for this, plus a regression test.

0001-Be-more-cautious-in-completing-Eshell-variable-assig.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#61778: 30.0.50; [PATCH] Be more cautious in completing Eshell variable assignments
>
>
>
>
> Date: 
>
> Sat, 25 Feb 2023 20:40:41 -0800
>
>
>
>
> On 2/25/2023 3:25 PM, Stefan Monnier via Bug reports for GNU Emacs, the 
> Swiss army knife of text editors wrote:
> > > Attached is a fix for this, plus a regression test.
> >
> > LGTM, thanks,
>
> Thanks. Pushed as 9565e34762. Closing this now.
>
>
> --- End Message ---