bug#61722: closed ((guix cpio) produces corrupted archives when there are non-ASCII filenames)

[GNU bug Tracking System]

Your message dated Sat, 25 Feb 2023 14:52:15 -0500
with message-id <875ybpfrps.fsf_-_@gmail.com>
and subject line Re: bug#61722: (guix cpio) produces corrupted archives when 
there are non-ASCII filenames
has caused the debbugs.gnu.org bug report #61722,
regarding (guix cpio) produces corrupted archives when there are non-ASCII 
filenames
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61722: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61722
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> (guix cpio) produces corrupted archives when there are non-ASCII filenames
>
>
>
>
> Date: 
>
> Wed, 22 Feb 2023 22:14:26 -0500
>
>
>
>
> Hi,
>
> It appears that the code we have to generate CPIO archives doesn't
> handle the presence of non-ASCII characters in the file names of files
> to be archived well:
>
> First, to make rpm usable on a Guix System:
>
> --8<---------------cut here---------------start------------->8---
> # mkdir /var/lib/rpm
> # chown root:users /var/lib/rpm
> # chmod g+rw /var/lib/rpm
> --8<---------------cut here---------------end--------------->8---
>
> Then, produce a problematic CPIO via 'guix pack -f rpm', which uses
> (guix cpio):
>
> --8<---------------cut here---------------start------------->8---
> $ rpm_archive=$(guix pack -R -C none -f rpm nss-certs)
> --8<---------------cut here---------------end--------------->8---
>
> Notice that it cannot be installed:
> --8<---------------cut here---------------start------------->8---
> $ mkdir /tmp/nss-certs
> # rpm --prefix=/tmp/nss-certs -i $rpm_archive
> error: unpacking of archive failed: cpio: Bad magic
> error: nss-certs-3.81-0.x86_64: install failed
> --8<---------------cut here---------------end--------------->8---
>
> Let's now inspect the cpio itself.
>
> --8<---------------cut here---------------start------------->8---
> $ guix shell rpm cpio
> [env]$ rpm2cpio $rpm_archive > nss-certs.cpio
> [env]$ cpio -t < nss-certs.cpio |& grep -B3 junk
> ./gnu/store/1klwvqm3njp070h982ydcix1gzf2zmdl-nss-certs-3.81/etc/ssl/certs/9482e63a.0
> ./gnu/store/1klwvqm3njp070h982ydcix1gzf2zmdl-nss-certs-3.81/etc/ssl/certs/9846683b.0
> ./gnu/store/1klwvqm3njp070h982ydcix1gzf2zmdl-nss-certs-3.81/etc/ssl/certs/988a38cb.0
> cpio: warning: skipped 248 bytes of junk
> --
> ./gnu/store/1klwvqm3njp070h982ydcix1gzf2zmdl-nss-certs-3.81/etc/ssl/certs/Microsoft_RSA_Root_Certificate_Authority_2017.pem
> ./gnu/store/1klwvqm3njp070h982ydcix1gzf2zmdl-nss-certs-3.81/etc/ssl/certs/NAVER_Global_Root_Certification_Authority.pem
> ./gnu/store/1klwvqm3njp070h982ydcix1gzf2zmdl-nss-certs-3.81/etc/ssl/certs/NetLock_Arany_=Class_Gold=_Főtanúsítvány.
> cpio: warning: skipped 4 bytes of junk
> --8<---------------cut here---------------end--------------->8---
>
> I haven't yet pin-pointed what the problem is.
>
> I could do with extra eyes :-).
>
> -- 
> Thanks,
> Maxim
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#61722: (guix cpio) produces corrupted archives when there are non-ASCII filenames
>
>
>
>
> Date: 
>
> Sat, 25 Feb 2023 14:52:15 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
> > Fixes <https://issues.guix.gnu.org/61722>.
> >
> > * guix/cpio.scm (file->cpio-header): Compute the file name length in bytes 
> > rather than in
> > characters.
> > (file->cpio-header*, special-file->cpio-header*): Likewise.
> > (write-cpio-archive): Likewise, and write the file name as UTF-8 bytes, not
> > textually, to avoid encoding it as ISO-8859-1.
>
> Pushed to master.
>
> Closing.
>
> -- 
> Thanks,
> Maxim
>
>
> --- End Message ---