bug#59927: closed ([PATCH] gnu: go-gopkg-in-yaml-v3: update after hash mismatch)

[GNU bug Tracking System]

Your message dated Wed, 15 Feb 2023 11:51:42 +0100
with message-id <87k00jcher.fsf@nckx>
and subject line Re: [PATCH] gnu: go-gopkg-in-yaml-v3: update after hash 
mismatch
has caused the debbugs.gnu.org bug report #59927,
regarding [PATCH] gnu: go-gopkg-in-yaml-v3: update after hash mismatch
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
59927: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59927
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: go-gopkg-in-yaml-v3: update after hash mismatch
>
>
>
>
> Date: 
>
> Fri,  9 Dec 2022 16:04:37 +0100
>
>
>
>
> It seems the authors of go yaml package made a bugfix
> in the repository and updated the v3 branch. Because of
> the resulting hash mismatch, a docker package couldn't
> be built.
>
> I updated the hash, changed a version from
> a branch of the repository to the v3.0.1 tag
> and applied guix style command.
> ---
>  gnu/packages/golang.scm | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index 70ddef52f1..b49fe7566d 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -38,6 +38,7 @@
>  ;;; Copyright © 2022 Dhruvin Gandhi <contact@dhruvin.dev>
>  ;;; Copyright © 2022 Nicolas Graves <ngraves@ngraves.fr>
>  ;;; Copyright © 2022 ( <paren@disroot.org>
> +;;; Copyright © 2022 Gleb Zakharov <snyssfx@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -4520,21 +4521,20 @@ (define-public go-gopkg-in-yaml-v2
>  (define-public go-gopkg-in-yaml-v3
>    (package
>      (name "go-gopkg-in-yaml-v3")
> -    (version "3")
> -    (source
> -     (origin
> -       (method git-fetch)
> -       (uri (git-reference
> -             (url "https://gopkg.in/yaml.v3";)
> -             (commit (string-append "v" version))))
> -       (file-name (git-file-name name version))
> -       (sha256
> -        (base32 "06f4lnrp494wqaygv09dggr2dwf3z2bawqhnlnnwiamg5y787k4g"))))
> +    (version "3.0.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://gopkg.in/yaml.v3";)
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "01b0wjb7yzv8wzzz2iim8mjpkwjnykcanrwiq06pkl89lr6gv8hn"))))
>      (build-system go-build-system)
>      (arguments
>       '(#:import-path "gopkg.in/yaml.v3"))
> -    (native-inputs
> -     (list go-gopkg-in-check-v1))
> +    (native-inputs (list go-gopkg-in-check-v1))
>      (home-page "https://gopkg.in/yaml.v3";)
>      (synopsis "YAML reader and writer for the Go language")
>      (description
>
> base-commit: 0ffa501f2b3e83ae56e9c2bd31418439090e869a
> -- 
> 2.38.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [PATCH] gnu: go-gopkg-in-yaml-v3: update after hash mismatch Date: Wed, 15 Feb 2023 11:51:42 +0100

Hi Gleb,

Thanks for this fix! I've applied it with suitable delay to the master branch.

I added a GNU ‘Change Log’ line to follow our standards[1]. Trivial in this case but always required:

* gnu/packages/golang.scm (go-gopkg-in-yaml-v3): Update to 3.0.1.

Don't mix unrelated changes: ‘guix style’ turned this trivially-audited patch:

 -(version "3")
 +(version "3.0.1")
 -(base32 "foo")
 +(base32 "bar")

into a 20-line diff :-)

Unfortunately, such changes are not considered copyrightable by current standards.

I disagreed with ‘guix style's’ mangling of the source field, so I just dropped it entirely.

Thanks again!

T G-R

[1]: https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html#Submitting-Patches

signature.asc
Description: PGP signature

--- End Message ---