bug#59640: closed ([PATCH] gnu: Add tilix.)

[GNU bug Tracking System]

Your message dated Sun, 8 Jan 2023 13:08:57 +0200
with message-id <Y7qkSRl0LkPWG8lQ@3900XT>
and subject line Re: [PATCH] gnu: Add tilix.
has caused the debbugs.gnu.org bug report #59640,
regarding [PATCH] gnu: Add tilix.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
59640: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59640
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add tilix.
>
>
>
>
> Date: 
>
> Sun, 27 Nov 2022 12:53:48 -0600
>
>
>
>
> * gnu/packages/terminals.scm (tilix): New variable.
> ---
>  gnu/packages/terminals.scm | 43 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
> index f6673388d2..69b982a727 100644
> --- a/gnu/packages/terminals.scm
> +++ b/gnu/packages/terminals.scm
> @@ -32,6 +32,7 @@
>  ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
>  ;;; Copyright © 2022 Felipe Balbi <balbi@kernel.org>
>  ;;; Copyright © 2022 ( <paren@disroot.org>
> +;;; Copyright © 2022 jgart <jgart@dismail.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -72,6 +73,7 @@ (define-module (gnu packages terminals)
>    #:use-module (gnu packages crates-io)
>    #:use-module (gnu packages crates-graphics)
>    #:use-module (gnu packages crypto)
> +  #:use-module (gnu packages dlang)
>    #:use-module (gnu packages docbook)
>    #:use-module (gnu packages fontutils)
>    #:use-module (gnu packages freedesktop)
> @@ -86,6 +88,7 @@ (define-module (gnu packages terminals)
>    #:use-module (gnu packages image)
>    #:use-module (gnu packages libcanberra)
>    #:use-module (gnu packages libevent)
> +  #:use-module (gnu packages libunwind)
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages man)
>    #:use-module (gnu packages ncurses)
> @@ -1307,6 +1310,46 @@ (define-public eternalterminal
>  (define-public wterm
>    (deprecated-package "wterm" foot))
>  
> +(define-public tilix
> +  (package
> +    (name "tilix")
> +    (version "1.9.5")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://github.com/gnunn1/tilix";)
> +               (commit version)))
> +        (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "0sb1hypg2276y8c2a5vivrkcxp70swddvhnd9h273if3kv6j879r"))))
> +    (build-system meson-build-system)
> +    (arguments
> +      '(#:glib-or-gtk? #t
> +        #:configure-flags '("-Dbuildtype=debugoptimized")
> +        #:phases
> +        (modify-phases %standard-phases 
> +            (delete 'check))))
> +    (inputs
> +     (list dbus
> +           gettext-minimal
> +           dconf
> +           gsettings-desktop-schemas
> +           libsecret
> +           libunwind))
> +    (native-inputs
> +      (list desktop-file-utils
> +            gtkd
> +            ldc
> +            pkg-config
> +            python-wrapper
> +            appstream))
> +    (home-page "https://gnunn1.github.io/tilix-web/";)
> +    (synopsis "Tiling terminal emulator following the Gnome Human Interface 
> Guidelines")
> +    (description "Tilix is a tiling terminal emulator following the
> +Gnome Human Interface Guidelines.")
> +    (license license:mpl2.0)))
> +
>  (define-public tio
>    (package
>      (name "tio")
> -- 
> 2.38.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [PATCH] gnu: Add tilix. Date: Sun, 8 Jan 2023 13:08:57 +0200

On Sat, Jan 07, 2023 at 10:13:56PM +0000, jgart wrote:
> Hi Efraim,
> 
> Thank you very much for fixing up and working on this patch. It is greatly 
> appreciated!
> 
> Here's a screenshot of me running tilix on GNOME 42.4 after building the 
> patch that you sent:
> 
> https://up.nixnet.services/wpex6t2q.png
> 
> I also ran the linter and just got
> 
> gnu/packages/terminals.scm:1351:5: tilix@1.9.5: label 'glib' does not match 
> package name 'glib:bin'
> 
> But the above is a warning that can be ignored, correct?

That's right.

I pushed the patch with a few more minor changes. I think this makes it
our first package actually using dlang.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

signature.asc
Description: PGP signature

--- End Message ---